Initial set of unit tests for static and local lamdbas #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thk123
commented
Feb 19, 2018
Collaborator
Author
There was a problem hiding this comment.
Note this is pulled into its own PR: diffblue#1856
mgudemann
force-pushed
the
feature/parse_bootstrapmethods_attribute
branch
from
bf53c54 to
a8f0116
Compare
thk123
force-pushed
the
feature/parse_bootstrapmethods_unittests
branch
2 times, most recently
from
10d4391 to
e7e0e22
Compare
Collaborator
Author
|
@mgudemann This is now ready for review and inclusion into the PR - I wonder if some of the tests are kind of redundant (e.g. we have the exhaustive static set, but then for member and local variable we just care about the ones that capture variables since they are the only ones that behave differently, what do you think? |
mgudemann
force-pushed
the
feature/parse_bootstrapmethods_attribute
branch
from
7e7c571 to
1069cae
Compare
mgudemann
reviewed
Feb 26, 2018
Owner
mgudemann
left a comment
mgudemann
left a comment
There was a problem hiding this comment.
looks good, just some minor comments
Owner
There was a problem hiding this comment.
we might also count to detect several matching entries
added 7 commits
February 26, 2018 13:58
thk123
force-pushed
the
feature/parse_bootstrapmethods_unittests
branch
from
e7e0e22 to
406fc00
Compare
mgudemann
merged this pull request
into
mgudemann:feature/parse_bootstrapmethods_attribute
mgudemann
pushed a commit
that referenced
this pull request
Aug 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently in a misnamed file
java_bytecode_parser_rclass_attribute.cpp